WPB-25915 add timeout and duration metric for conversation migration#5244
Merged
battermann merged 23 commits intoJun 11, 2026
Merged
Conversation
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds timeout handling and duration observability for background-worker conversation migrations to make stuck per-conversation attempts visible and fail-fast.
Changes:
- Adds optional
timeouttoMigrationOptionsand applies it to per-conversation migration attempts. - Registers and records a Prometheus histogram for conversation migration attempt durations by outcome.
- Documents the new timeout setting and updates package dependencies for
Timeouttime-unit support.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
services/background-worker/src/Wire/PostgresMigrations.hs |
Registers and passes the new conversation migration duration histogram. |
services/background-worker/src/Wire/BackgroundWorker.hs |
Updates existing MigrationOptions constructor calls for the new timeout field. |
libs/wire-subsystems/src/Wire/Migration.hs |
Adds timeout configuration and timeout exception type. |
libs/wire-subsystems/src/Wire/ConversationStore/Migration.hs |
Applies per-conversation timeout logic and records duration metrics. |
libs/types-common/types-common.cabal |
Adds polysemy-time dependency. |
libs/types-common/src/Util/Timeout.hs |
Derives TimeUnit for Timeout. |
libs/types-common/default.nix |
Adds polysemy-time to Nix dependencies. |
docs/src/developer/reference/config-options.md |
Documents the new migration timeout option. |
changelog.d/5-internal/WPB-25915 |
Adds a changelog entry file, but it is currently empty. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akshaymankar
requested changes
Jun 2, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Akshay Mankar <akshay@wire.com>
Co-authored-by: Akshay Mankar <akshay@wire.com>
Co-authored-by: Akshay Mankar <akshay@wire.com>
Co-authored-by: Akshay Mankar <akshay@wire.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
battermann
force-pushed
the
WPB-25915-add-timeout-and-duration-metric-for-conversation-migration
branch
from
4c4c132 to
cd421ac
Compare
Contributor
|
@battermann the CI was flaky and it lacks an approval from @akshaymankar |
akshaymankar
approved these changes
Jun 10, 2026
akshaymankar
left a comment
akshaymankar
left a comment
Member
There was a problem hiding this comment.
Looks good. Nits in comments.
Comment on lines
+172
to
+173
| migrateConversationWithLock timeout_ cid = | ||
| withExclusiveMigrationLockAndTimeout timeout_ migDuration [cid] $ migrateConversation cid migCounter |
Member
There was a problem hiding this comment.
This seems to be the only migration where we pulled out the withExclusiveMigrationLockAndTimeout outside the migrate<Thing> function. Why so?
Contributor
Author
There was a problem hiding this comment.
I checked the code again. It looks correct for all migrations. For the other migrations the code is inlined and for conversations it is extracted into a helper function. That is all. There is no reason.
Let me know if you want this changed, otherwise I will merge. 🙏
Member
There was a problem hiding this comment.
All good, I was just curious what happened. 
Co-authored-by: Akshay Mankar <akshay@wire.com>
battermann
deleted the
WPB-25915-add-timeout-and-duration-metric-for-conversation-migration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25915
I have tested that it works. However, those test cannot be committed, because they hook into the production migration code to simulate the blocking conversation migration.
Checklist
changelog.d